Skip to content

Infer the types of function/closure arguments when captured by an exit test. #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented May 25, 2025

This PR adds the ability to infer the type of a parameter of a function or closure that encloses an exit test. For example, x here:

func f(x: Int) async {
  await #expect(processExitsWith: .failure) { [x] in
    ...
  }
}

This inference still fails if a parameter is shadowed by a variable with an incompatible type; we still need something like decltype() to solve for such cases. We emit a custom diagnostic of the form "🛑 Type of captured value 'x' is ambiguous" if the inferred type of the captured value doesn't match what the compiler thinks it is (see #1146). Still, being able to capture @Test function arguments with minimal ceremony is helpful:

@Test(arguments: 0 ..< 100) func f(i: Int) async {
  await #expect(exitsWith: .failure) { [i] in
    ...
  }
}

Also type inference for literals because "why not?"

Note

Exit test value capture remains an experimental feature.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

…t test.

This PR adds the ability to infer the type of a parameter of a function or closure that encloses an exit test. For example, `x` here:

```swift
func f(x: Int) async {
  await #expect(processExitsWith: .failure) { [x] in
    ...
  }
}
```

This inference still fails if a parameter is shadowed by a variable with an incompatible type; we still need something like `decltype()` to solve for such cases. Still, being able to capture `@Test` function arguments with minimal ceremony is helpful:

```swift
@test(arguments: 0 ..< 100) func f(i: Int) async {
  await #expect(exitsWith: .failure) { [i] in
    ...
  }
}
```
@grynspan grynspan added this to the Swift 6.x milestone May 25, 2025
@grynspan grynspan self-assigned this May 25, 2025
@grynspan grynspan added enhancement New feature or request exit-tests ☠️ Work related to exit tests parameterized-testing Related to parameterized testing functionality labels May 25, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan requested a review from stmontgomery June 13, 2025 20:27
@grynspan grynspan merged commit 567285e into main Jun 13, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/exit-tests-infer-function-parameter-types branch June 13, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exit-tests ☠️ Work related to exit tests parameterized-testing Related to parameterized testing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants