-
Notifications
You must be signed in to change notification settings - Fork 111
Infer the types of function/closure arguments when captured by an exit test. #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
grynspan
merged 5 commits into
main
from
jgrynspan/exit-tests-infer-function-parameter-types
Jun 13, 2025
Merged
Infer the types of function/closure arguments when captured by an exit test. #1130
grynspan
merged 5 commits into
main
from
jgrynspan/exit-tests-infer-function-parameter-types
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t test. This PR adds the ability to infer the type of a parameter of a function or closure that encloses an exit test. For example, `x` here: ```swift func f(x: Int) async { await #expect(processExitsWith: .failure) { [x] in ... } } ``` This inference still fails if a parameter is shadowed by a variable with an incompatible type; we still need something like `decltype()` to solve for such cases. Still, being able to capture `@Test` function arguments with minimal ceremony is helpful: ```swift @test(arguments: 0 ..< 100) func f(i: Int) async { await #expect(exitsWith: .failure) { [i] in ... } } ```
@swift-ci test |
@swift-ci test |
@swift-ci test |
2 tasks
stmontgomery
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
exit-tests
☠️ Work related to exit tests
parameterized-testing
Related to parameterized testing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to infer the type of a parameter of a function or closure that encloses an exit test. For example,
x
here:This inference still fails if a parameter is shadowed by a variable with an incompatible type; we still need something like
decltype()
to solve for such cases. We emit a custom diagnostic of the form "🛑 Type of captured value 'x' is ambiguous" if the inferred type of the captured value doesn't match what the compiler thinks it is (see #1146). Still, being able to capture@Test
function arguments with minimal ceremony is helpful:Also type inference for literals because "why not?"
Note
Exit test value capture remains an experimental feature.
Checklist: