PackageLoading: support non-Unix platforms for PkgConfig #5517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
May 16, 2022
tomerd
reviewed
May 16, 2022
tomerd
reviewed
May 16, 2022
tomerd
reviewed
May 16, 2022
tomerd
reviewed
May 16, 2022
tomerd
reviewed
May 16, 2022
pkg-config is a common utility on UNIX systems, but does not play very well with Windows. This adjusts the path separator character to match the platform as well as uses `AbsolutePath` APIs to work with paths as a means of getting the platform specific path separator character. It also introduces the ability to specify the pkgconfig tool itself which is needed for Windows which does not support an arbitrary executable.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg-config is a common utility on UNIX systems, but does not play very
well with Windows. This adjusts the path separator character to match
the platform as well as uses
AbsolutePathAPIs to work with paths asa means of getting the platform specific path separator character. It
also introduces the ability to specify the pkgconfig tool itself which
is needed for Windows which does not support an arbitrary executable.