Skip to content

Conversation

@rauhul
Copy link
Member

@rauhul rauhul commented Jan 17, 2024

Updates the byline to link to all of the author's social links using the appropriate icon for each. Additionally, adds support for mastodon profiles.

Fixes #477

Instead of linking the author name, the links now appear as right-aligned icons. What do y'all think of this?

Screenshot 2024-01-17 at 10 32 41 AM Screenshot 2024-01-17 at 10 54 36 AM

Updates the byline to link to all of the author's social links using the
appropriate icon for each. Additionally, adds support for mastodon
profiles.

Fixes #477
@rauhul
Copy link
Member Author

rauhul commented Jan 17, 2024

@compnerd are you ok with me including a link to your mastodon profile in this PR?

@rauhul
Copy link
Member Author

rauhul commented Jan 17, 2024

Also I noticed the mastodon icon seems to be truncated a bit, I will try to figure out how to fix that...

edit: fixed

@compnerd
Copy link
Member

@rauhul yeap, that should be fine :)

@rauhul rauhul added the enhancement New feature or request label Jan 17, 2024
@dempseyatgithub
Copy link
Contributor

The site changed to prefer Github profiles, and missing Github profile info/links were added, because Twitter / X profiles were no longer publicly viewable without having an account and being signed in.

Details are available in PRs #408 and #409.

The website workgroup will discuss this in an upcoming meeting.

@dempseyatgithub dempseyatgithub added the workgroup-to-discuss Issue/PR to be discussed by the SWWG in the next meeting label Jan 30, 2024
@dempseyatgithub
Copy link
Contributor

First, @rauhul, thank you for the issues and pull requests you have submitted to the site.

The website workgroup discussed this pull request and more generally the approach that Swift.org should take to linking to author information.

The consensus was that it’s important to link to additional author information, but it’s not a goal of the site to build out profiles for authors.

Instead of adding links to multiple profiles per author across multiple services, as in PR #481, the workgroup decided to use only GitHub profiles links for author profiles.

The reasons for this choice are:

  • Github profiles can be viewed without being signed in / having an account. So they are accessible to all readers. (Twitter/X requires being signed in, which spurred the original preference for GitHub profiles.)
  • GitHub profiles are flexible and allow a user to provide multiple social media accounts as well as a website and email address.
  • GitHub is the service used for hosting Swift projects. The Swift.org blog submission process includes submitting a PR, so , to date, all contributors to Swift.org have a GitHub account.
  • With a growing number of social networks, there is a maintenance cost in deciding which services to support and updating author info and link markup for multiple services.

This approach gives readers a way to learn more about authors, gives authors a flexible way to provide a variety of contact/account through their GitHub profile, and provides Swift.org with a more easily maintained approach moving forward.

Thank you very much again @rauhul for this PR. Although it's not the direction that the workgroup decided to go in, it really focused attention on the issue.

PR #507 implements the changes agreed on by the workgroup, so I am closing this PR in favor of #507.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request workgroup-to-discuss Issue/PR to be discussed by the SWWG in the next meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display links to author mastodon/twitter

4 participants