Skip to content

Revert "Add link title support for commonmark" #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

franklinsch
Copy link
Contributor

Reverts #140

This is breaking Swift-DocC tests in toolchain builds: https://ci.swift.org/job/oss-swift-package-amazon-linux-2/2319/consoleText

@franklinsch
Copy link
Contributor Author

@swift-ci please test

Copy link

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Kyle-Ye
Copy link
Contributor

Kyle-Ye commented Sep 21, 2023

Maybe we should prefer to merge swiftlang/swift-docc#708.

@eeckstein
Copy link

Yes, let's merge the test fixes

@QuietMisdreavus
Copy link
Contributor

With the associated test fixes landed in Swift-DocC, should this PR be closed? @eeckstein have toolchain builds been successful after landing the other PR?

@franklinsch
Copy link
Contributor Author

Yes, I'll close this now

@Kyle-Ye Kyle-Ye deleted the revert-140-bugfix/link-uri branch September 21, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants