Skip to content

Reflect variant name in component group ids #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Jun 26, 2025

This is a follow up change to #428. In this PR we are making component group IDs reflect the variant in the name they are carrying.

There is no functional change in this change, changes are only to component ids.

@mhegazy mhegazy changed the title Reflect variant name in component ids Reflect variant name in component group ids Jun 26, 2025
@compnerd
Copy link
Member

compnerd commented Jul 1, 2025

Testing at https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/5943/

@compnerd
Copy link
Member

compnerd commented Jul 2, 2025

The installer built successfully with this change; merging to unblock further work.

@compnerd compnerd merged commit abe687a into swiftlang:main Jul 2, 2025
@mhegazy mhegazy deleted the variant-specific-components branch July 3, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants