Continue to move FoundationInternationalization tests to swift-testing #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
itingliu
approved these changes
Jun 30, 2025
| } | ||
| #endif // (arch(x86_64) || arch(arm64)) && FOUNDATION_FRAMEWORK | ||
| #endif // _pointerBitWidth(_64) && FOUNDATION_FRAMEWORK |
There was a problem hiding this comment.
I think with this change we can remove this #if FOUNDATION_FRAMEWORK. I'd be happy to do that in a follow up separately.
There was a problem hiding this comment.
Sounds good! Yeah I'd prefer to do it in a separate change so that this is as close to behaviorally equivalent as possible in case there's any latent issues that testing on new platforms like Linux/Windows would pick up to reduce the risk of this change
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves most of the remaining test cases to swift-testing (with a few still remaining that I'm working on)