FoundationEssentials,FoundationInternationalization: adjust for aliasing #1340
+40
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmschonfeld
reviewed
Jun 9, 2025
Sources/FoundationEssentials/FileManager/FileOperations+Enumeration.swift
Show resolved
Hide resolved
itingliu
reviewed
Jun 11, 2025
Sources/FoundationEssentials/FileManager/FileOperations+Enumeration.swift
Show resolved
Hide resolved
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please test |
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please test |
|
This should really go in with the ICU changes IMO. This is one of the last pieces needed to start exploring building the early swift-driver on Windows. |
parkera
approved these changes
Jul 7, 2025
|
@compnerd do you want to handle synchronizing the merge of these two PRs when you are ready? |
|
@parkera thanks! yeap - I'll go ahead and synchronise these two |
When enabling symbol renaming in ICU, we import the functions as an alias. This causes the implicit nullability translation with C to disappear. Make these conversions explicit so that we can enable symbol renaming on non-Darwin platforms.
|
Cross-repo tested at https://ci-external.swift.org/job/swift-PR-windows/42872/ |
|
Please test with following PRs: @swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling symbol renaming in ICU, we import the functions as an alias. This causes the implicit nullability translation with C to disappear. Make these conversions explicit so that we can enable symbol renaming on non-Darwin platforms.