Cherrypick fixes for issue 74866 to swift/release/5.10 #9478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context-related instructions in the prologue and the epilogue. This fixes an error from checkARM64Instructions() in MCWin64EH.cpp. Cherrypick from commit llvm/llvm-project@0ecd884 Cherrypick PR swiftlang#7533
Also add ExtParameterInfos to the argument list of arrangeFreeFunctionCall. Cherrypick PR llvm#111597
|
@swift-ci please test |
hjyamauchi
changed the title
|
We don't usually continue to work on old release branches; is this really necessary? |
|
I believe so: swiftlang/swift#74866 (comment) |
|
Alright, LGTM then. |
rjmccall
approved these changes
Nov 4, 2024
|
We decided not to cherrypick the fixes to 5.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherrypicks the fixes that are necessary to fix the windows arm64 compiler.