[lldb/test] Stop recording fundamental return types (NFC) #2423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that recording fundamental return type is bogus. This can trigger asserts when running a test with reproducers so this patch updates the `SBTarget::IsLoaded` test to stop recording them. Differential Revision: https://reviews.llvm.org/D95686 Signed-off-by: Med Ismail Bennani <[email protected]>
|
@swift-ci test macOS Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that recording fundamental return type is bogus.
This can trigger asserts when running a test with reproducers so this
patch updates the
SBTarget::IsLoadedtest to stop recording them.Differential Revision: https://reviews.llvm.org/D95686
Signed-off-by: Med Ismail Bennani [email protected]