Skip to content

[GlobalISel] Check if branches use the same MBB in matchOptBrCondByInvertingCond #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

ornata
Copy link

@ornata ornata commented Feb 3, 2021

If the G_BR + G_BRCOND in this combine use the same MBB, then it will infinite
loop. Don't allow that to happen.

Differential Revision: https://reviews.llvm.org/D95895

(cherry picked from commit 02d4b36)

rdar://73842004

…vertingCond

If the G_BR + G_BRCOND in this combine use the same MBB, then it will infinite
loop. Don't allow that to happen.

Differential Revision: https://reviews.llvm.org/D95895

(cherry picked from commit 02d4b36)

rdar://73842004
@ornata
Copy link
Author

ornata commented Feb 3, 2021

@swift-ci please test

@ornata
Copy link
Author

ornata commented Feb 3, 2021

Test failures on Linux platform are all unrelated to this commit:

Failed Tests (10):
  Clangd :: background-index.test
  Clangd :: check-fail.test
  Clangd :: check.test
  Clangd :: compile-commands-path-in-initialize.test
  Clangd :: path-mappings.test
  Clangd :: system-include-extractor.test
  Clangd :: target_info.test
  Clangd Unit Tests :: ./ClangdTests/DirectoryBasedGlobalCompilationDatabaseCacheTest.Cacheable
  Clangd Unit Tests :: ./ClangdTests/GlobalCompilationDatabaseTest.BuildDir
  Clangd Unit Tests :: ./ClangdTests/GlobalCompilationDatabaseTest.DiscoveryWithNestedCDBs

This is safe to merge.

@ornata ornata merged commit 289510f into apple/stable/20210107 Feb 3, 2021
@ornata ornata deleted the PR-73842004 branch February 3, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant