[lldb] Fix TypeSystemSwiftTypeRe for NDEBUG builds #2419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
adrian-prantl
approved these changes
Feb 2, 2021
| @@ -2154,11 +2155,11 @@ TypeSystemSwiftTypeRef::GetBitSize(opaque_compiler_type_t type, | |||
| return {}; | |||
| }; | |||
| FALLBACK(GetBitSize, (ReconstructType(type), exe_scope)); | |||
| if (exe_scope && exe_scope->CalculateProcess()) | |||
| if (exe_scope && exe_scope->CalculateProcess()) { | |||
There was a problem hiding this comment.
This one is NFC, right? Still a good idea, of course.
There was a problem hiding this comment.
Probably, I wasn't sure if the whole VALIDATE_AND_RETURN would get compiled out or not, if not then this is indeed a NO-OP.
The 5.4 branch is fine. I remember fixing something similar last rebranch and I probably just forgot to cherrypick it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.