[lldb] Update for removal of SourceFile::addImports #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
a-balance-of-payments-deficit
branch
from
73bd5bd to
7fae3a0
Compare
Additional modules to implicitly import now need to be provided upfront when constructing the ModuleDecl. To enable this change, split `PerformUserImport` into `GetImplicitImports`, which retrieves the necessary modules to import, and `CacheUserImports`, which deals with caching the imports from the parsed source file such that they're available to future expression evaluations. This commit also renames `PerformAutoImport` to `GetCompileUnitImports` to better match the other two methods.
Imports need to be resolved before the SwiftASTManipulator is run, as it can query interface types.
hamishknight
force-pushed
the
a-balance-of-payments-deficit
branch
from
7fae3a0 to
f53d12b
Compare
|
@swift-ci please test |
adrian-prantl
approved these changes
Apr 15, 2020
|
Thanks for the review!
No, it should do the same thing as the old API, the only difference being that import resolution now handles adding the imports to the file. |
|
@swift-ci please test |
swift-ci
pushed a commit
that referenced
this pull request
Jul 11, 2023
To complement the bf16 expansion and truncation patterns added to ExpandOps, define a pass that replaces, for any arithmetic operation op, %y = arith.op %v0, %v1, ... : T with %e0 = arith.expf %v0 : T to U %e1 = arith.expf %v1 : T to U ... %y.exp = arith.op %e0, %e1, ... : U %y = arith.truncf %y.exp : U to T This allows for "emulating" floating-point operations not supported on a given target (such as bfloat operations or most arithmetic on 8-bit floats) by extending those types to supported ones, performing the arithmetic operation, and then truncating back to the original type (which ensures appropriate rounding behavior). The lowering of the extf and truncf ops introduced by this transformation should be handled by subsequent passes. Reviewed By: rsuderman Differential Revision: https://reviews.llvm.org/D154539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftlang/swift#31016 removes this API. Additional modules to be implicitly imported now need to be provided upfront when constructing the
ModuleDecl.To enable this change, split
PerformUserImportintoGetImplicitImports, which retrieves the necessary modules to import, andCacheUserImports, which deals with caching the imports from the parsed source file such that they're available to future expression evaluations.Note I'm not planning on merging this until after the 5.3 re-branch.