fix: don't resolve via svelte field for prebundled libraries #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actually get used
bluwy
approved these changes
Nov 3, 2022
Member
|
Wouldn't this be roughly equivalent to #459 for SvelteKit users? |
Member
Author
|
No, this just prevents resolving dependencies via svelte field again after they have been prebundled. Which is a bug causing the prebundled dependencies not being used. |
benmccann
reviewed
Nov 8, 2022
benmccann
reviewed
Nov 8, 2022
…undle, resolve excluded when prebundle is active
…round and exclude it from optimize
bluwy
approved these changes
Nov 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they actually get used
This pushes the svelte dependencies to optimizeDeps.include when prebundleSvelteLibraries is true so needs a bit more testing.
One sideeffect is that cold start of vite will be slower, but less restarts happen due to optimization being done earlier.