Skip to content

fix: handle non-semver-style dependency versions #13850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dummdidumm merged 3 commits into from
Jun 4, 2025
+12 −1
Merged

fix: handle non-semver-style dependency versions #13850

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e26d8b4
fix: handle non-semver-style dependency versions
dummdidumm Jun 2, 2025
4157e9d
Update packages/package/src/typescript.js
dummdidumm Jun 2, 2025
13ff753
Update packages/package/src/typescript.js
dummdidumm Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smooth-trains-applaude.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: handle non-semver-style dependency versions
8 changes: 7 additions & 1 deletion packages/package/src/typescript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@
const require = createRequire(import.meta.url);
const pkg = load_pkg_json(cwd);
const svelte_dep = pkg.peerDependencies?.svelte || pkg.dependencies?.svelte || '3.0';
const no_svelte_3 = !semver.intersects(svelte_dep, '^3.0.0');
let no_svelte_3;
try {
no_svelte_3 = !semver.intersects(svelte_dep, '^3.0.0');
} catch (_) {

Check failure on line 34 in packages/package/src/typescript.js

View workflow job for this annotation

GitHub Actions / lint-all 

'_' is defined but never used
// Not all version specs are valid semver, e.g. "latest" or "next" or catalog references
no_svelte_3 = true;
}
await emitDts({
libRoot: input,
svelteShimsPath: no_svelte_3
Expand Down
Loading