Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-geese-serve.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: service worker base path in dev mode
2 changes: 1 addition & 1 deletion packages/kit/src/exports/vite/dev/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ export async function dev(vite, vite_config, svelte_config) {
res.writeHead(200, {
'content-type': 'application/javascript'
});
res.end(`import '${to_fs(resolved)}';`);
res.end(`import '${svelte_config.kit.paths.base}${to_fs(resolved)}';`);
} else {
res.writeHead(404);
res.end('not found');
Expand Down
15 changes: 14 additions & 1 deletion packages/kit/test/apps/options-2/test/test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import path from 'node:path';
import process from 'node:process';
import { fileURLToPath } from 'node:url';
import { expect } from '@playwright/test';
import { test } from '../../../utils.js';

Expand Down Expand Up @@ -56,7 +58,18 @@ test.describe('paths', () => {
});

test.describe('Service worker', () => {
if (process.env.DEV) return;
if (process.env.DEV) {
test('import proxy /basepath/service-worker.js', async ({ request }) => {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const response = await request.get('/basepath/service-worker.js');
const content = await response.text();
expect(content).toEqual(
`import '${path.join('/basepath', '/@fs', __dirname, '../src/service-worker.js')}';`
);
});

return;
}

test('build /basepath/service-worker.js', async ({ baseURL, request }) => {
const response = await request.get('/basepath/service-worker.js');
Expand Down
Loading