Skip to content

Conversation

@omermorad
Copy link
Collaborator

Relates #931

@omermorad omermorad self-assigned this Nov 20, 2025
@omermorad omermorad marked this pull request as draft November 20, 2025 17:29
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 82.92683% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.90%. Comparing base (32bec03) to head (9b5acec).

Files with missing lines Patch % Lines
...ckages/di/injection-js/src/class-ctor-reflector.ts 77.41% 3 Missing and 4 partials ⚠️

❌ Your patch check has failed because the patch coverage (82.92%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #934      +/-   ##
==========================================
- Coverage   92.52%   91.90%   -0.63%     
==========================================
  Files          25       27       +2     
  Lines         589      630      +41     
  Branches       99      108       +9     
==========================================
+ Hits          545      579      +34     
- Misses         35       38       +3     
- Partials        9       13       +4     
Flag Coverage Δ
core.unit 93.44% <ø> (ø)
di.injectionjs 82.92% <82.92%> (?)
di.inversify 93.61% <ø> (ø)
di.nestjs 87.25% <ø> (ø)
doubles.jest 100.00% <ø> (ø)
doubles.sinon 100.00% <ø> (ø)
doubles.vitest 100.00% <ø> (ø)
unit 77.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omermorad omermorad marked this pull request as ready for review November 20, 2025 17:33
@omermorad omermorad changed the title feat(adapters.injectionjs): add injection-js dependency injection adapter refactor(adapters.injectionjs,unit): add injection-js dependency injection adapter Nov 21, 2025
@omermorad omermorad changed the title refactor(adapters.injectionjs,unit): add injection-js dependency injection adapter refactor(adapters.injectionjs,unit): add injection-js dependency injection adapter support Nov 21, 2025
@omermorad omermorad force-pushed the feat/iss-931/support-injectionjs-adapter branch from c6390f6 to 8df7a81 Compare November 27, 2025 17:21
@omermorad omermorad changed the base branch from master to next November 27, 2025 23:00
@iddan iddan force-pushed the next branch 2 times, most recently from 3120956 to 32bec03 Compare December 7, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants