🐛(frontend) Collaboration upgrade #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
added
dependencies
AntoLC
force-pushed
the
fix/collaboration-upgrade
branch
from
70a689b to
ff5b36e
Compare
lunika
reviewed
Mar 6, 2025
CHANGELOG.md
Outdated
Comment on lines
428
to
429
| [unreleased]: https://github.com/numerique-gouv/impress/compare/v2.4.0...main | ||
| [v2.4.0]: https://github.com/numerique-gouv/impress/releases/v2.4.0 |
AntoLC
force-pushed
the
fix/collaboration-upgrade
branch
from
78c1f6e to
7a3046b
Compare
lunika
reviewed
Mar 6, 2025
src/frontend/package.json
Outdated
| @@ -40,6 +40,7 @@ | |||
| "@typescript-eslint/parser": "8.23.0", | |||
| "docx": "9.1.1", | |||
| "eslint": "8.57.0", | |||
| "prosemirror-view": "1.37.2", | |||
There was a problem hiding this comment.
Do we have to set a rule in renovate configuration ? Like ignoring it because we want to manage the version our self ?
There was a problem hiding this comment.
We could but Blocknote made a fix for these 2 already:
- fix: compatibility with new react-pdf TypeCellOS/BlockNote#1494
- fix: upgrade prosemirror view and use correct clipboard import TypeCellOS/BlockNote#1431
Docx seems to work with newer version as well.
I have already a PR opened about bumping Blocknote (#640), I think it will be ready before renovate tried to bump them.
lunika
approved these changes
Mar 6, 2025
We upgrade blocknote to 0.23.2-hotfix.0, it includes a fix with the collaboration.
Blocknote does not pinned the version. We get bumped version instead of the version we want. We pin the version of blocknote globally to avoid this issue.
AntoLC
force-pushed
the
fix/collaboration-upgrade
branch
from
7a3046b to
8f3cd20
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Last version of Blocknote (0.23.2) has a bug with the collaboration.
We upgrade Blocknote to
0.23.2-hotfix.0that fix this problem.Proposal