Add new matcher toHaveReceivedCommandExactlyOnceWith #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common practice seems to be to not call tests "it should" but rather specify the expected behaviour as facts, e.g. use "it passes" instead of "it should pass"
Whenever compare call arguments (e.g. `toHaveReceivedCommandWith` we internally use ObjectContaining and `asymmetricMatch` of `vitest`. This is not only to allow partial matches, but also in order to use something like `expect.any(String)` or `expect.stringMatching()`. This now adds some tests to verify this does actually work as intended.
This includes a major version bump of @vitest/expect, so we should later also bump the major version of our package.
When testing our custom matcher we want to ensure they also fail a test appropiatly (e.g. you test a mock was never called, but it was indeed called; we want to know this fails) Previously we did write a test like a user would write the test but instead of using `it` we use `if.fails`. While this did work, we are unable to validate *why* the test fails. We now don't assume failing tests but instead we wrap these in `expect(...).toThrow`. This should not only be easier to read but also allows us to capture the error message to validate the test fails for the correct reason.
The new matcher can be used in similar way as [toHaveBeenCalledExactlyOnceWith][1] of vitest but targeted against AWS mocks [1]: vitest-dev/vitest#6894
stschulte
force-pushed
the
new-matcher
branch
from
d83fea4 to
38bd57f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new matcher can be used in similar way as
toHaveBeenCalledExactlyOnceWith of vitest but targeted against
AWS mocks