Online foreign key support #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplunkett-stripe
force-pushed
the
bplunkett/online-fks
branch
from
e3c2f91 to
8611c63
Compare
bplunkett-stripe
commented
Jul 7, 2024
| return nil, nil | ||
| } | ||
|
|
||
| func buildForeignKeyConstraintDiff(fsg *foreignKeyConstraintSQLVertexGenerator, addedTablesByName map[string]schema.Table, old, new schema.ForeignKeyConstraint) (foreignKeyConstraintDiff, bool, error) { |
Collaborator
Author
There was a problem hiding this comment.
This aligns more with the new paradigm of sql vertex generators: the diff function should call into the sql vertex generator (if possible) to reduce duplicated logic.
alexaub-stripe
approved these changes
Jul 8, 2024
Collaborator
alexaub-stripe
left a comment
alexaub-stripe
left a comment
There was a problem hiding this comment.
LGTM! Couple comments non-blocking
| // buildChildrenByPartitionedIndexNameMap builds a map of indexes by their parent index name. This map will include | ||
| // all descendents, not just direct descendents. For example, if foobar idx has 5 children and each of those children | ||
| // has 5 children, the slice for foobar index wil contain 30 indexes (the 5 direct children and the 25 "grandchildren") | ||
| func buildChildrenByPartitionedIndexNameMap(indexes []schema.Index) map[string][]schema.Index { |
Collaborator
There was a problem hiding this comment.
thought: Could this function be a fair amount simpler with a findRoot(node, nodesByParent) helper? You avoid having to reason about popping/pushing onto currentNodes too.
- Build childrenByDirectParent map
- For each index, call
findRoot(index, childrenByDirectParent) - Add child to root entry in output map
Optionally you could memoize findRoot if you care about performance
| } | ||
|
|
||
| func buildForeignKeyConstraintDiff(fsg *foreignKeyConstraintSQLVertexGenerator, addedTablesByName map[string]schema.Table, old, new schema.ForeignKeyConstraint) (foreignKeyConstraintDiff, bool, error) { | ||
| if _, isOnNewTable := addedTablesByName[new.OwningTable.GetName()]; isOnNewTable { |
Collaborator
There was a problem hiding this comment.
Does addedTablesByName include the case where the owning/referencing tables are themselves recreated? Or is it only net new tables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Online foreign key support via
VALIDATE.Unfortunately, it is not possible to add
NOT VALIDconstraints to partitioned tables, so this strategy can only work when adding foreign keys to normal tables. It does work on partitions, so if a user really wanted to add foreign key constraints safely on a partitioned table, they could just add n foreign key constraints, one per partition, rather than just 1.Motivation
Fixes #97
Testing
Tested via acceptance tests