Skip to content

Multi-schema support #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bplunkett-stripe merged 4 commits into from
Feb 5, 2024
Merged

Multi-schema support #104

bplunkett-stripe merged 4 commits into from
Feb 5, 2024

Conversation

@bplunkett-stripe
Copy link
Collaborator

@bplunkett-stripe bplunkett-stripe commented Feb 3, 2024 •
edited
Loading

Description

Multi-schema support.

This PR adds:

  • Support for adding/creating named schemas (I call them NamedSchemas to distinguish from the existing (Database)Schema objects
  • Updates our acceptance tests to check for schema edge cases. It's unlikely we cover nearly all edge cases, but I'm trying to keep the # of acceptance tests at an acceptable number
  • Removes the gate on providing custom schema options to the Plan generator
  • Updates the docs

Motivation

Fixes #94

Testing

Tested via unit tests

@bplunkett-stripe bplunkett-stripe force-pushed the bplunkett/add-multi-schema-support branch 6 times, most recently from 5697f35 to 286eb6c Compare February 3, 2024 00:53
@bplunkett-stripe bplunkett-stripe force-pushed the bplunkett/add-multi-schema-support branch from 286eb6c to 133f354 Compare February 3, 2024 00:57
@bplunkett-stripe bplunkett-stripe merged commit 43a6d6f into main Feb 5, 2024
@bplunkett-stripe bplunkett-stripe deleted the bplunkett/add-multi-schema-support branch February 5, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexaub-stripe alexaub-stripe Awaiting requested review from alexaub-stripe

1 more reviewer

@ericw-stripe ericw-stripe ericw-stripe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for non-public schemas

3 participants

@bplunkett-stripe @ericw-stripe