Add exclude schemas #100
Merged
Add exclude schemas #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplunkett-stripe
commented
Feb 1, 2024
internal/schema/schema.go
Outdated
Collaborator
Author
There was a problem hiding this comment.
We technically don't need to build a excludeSchemasFilter if there is an includeSchemasFilter, however I think the flow of control here is a bit simpler.
Everything will also still work if we got rid of the intersection check with this method! I.e., if you include and exclude a schema, then it makes sense that it would be excluded. (true && false) -> false
bplunkett-stripe
commented
Feb 1, 2024
pkg/tempdb/factory.go
Outdated
Collaborator
Author
There was a problem hiding this comment.
This is the core of the PR. Without this, acceptance tests would fail because they would try to diff out the metadata table.
bplunkett-stripe
force-pushed
the
bplunkett/add-exclude-schemas
branch
from
77e9d28 to
2051e2f
Compare
ericw-stripe
reviewed
Feb 1, 2024
internal/schema/filters_test.go
Outdated
| for _, filter := range tc.filters { | ||
| filters = append(filters, newFakeNameFilter(t, filter).filter) | ||
| } | ||
| assert.Equal(t, tc.expectedOut, orNameFilter(filters...)(tc.input)) |
ericw-stripe
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using temp db factories (which have metadata tables), we need to tell the schema fetcher to ignore those tables.
This also technically switches acceptance tests to fetch non-public schemas; however, none of our tests actually have non-public schemas.
The final step for supporting non-public schemas at this point is validating everything is actually working through the acceptance tests, updating the documentation, and removing the gate.
Motivation
#94
Testing
Acceptance tests