Issue project 52 u128 #2341
Closed
Issue project 52 u128 #2341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm doing on last quick pass over this to clean up rebase cruft and then rebasing. |
jbaublitz
force-pushed
the
issue-project-52-u128
branch
from
780951d to
35efcde
Compare
Member
Author
|
Okay, this is ready. |
mulkieran
requested changes
Jan 8, 2021
Member
mulkieran
left a comment
mulkieran
left a comment
There was a problem hiding this comment.
Just two points, otherwise looks good.
mulkieran
reviewed
Jan 8, 2021
Member
mulkieran
left a comment
mulkieran
left a comment
There was a problem hiding this comment.
Yes, this looks good. Moving to pending.
mulkieran
requested changes
Jan 9, 2021
Member
mulkieran
left a comment
mulkieran
left a comment
There was a problem hiding this comment.
Ok! Please close and make new PR for final review. Please add in as a separate commit use of AsRawFd as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2320
@mulkieran I think this is ready for review. Based on this, it appears that
u128is supported on all architectures that Rust supports, even 32 bit ones. Given that our concern was stability, I think that should no longer be an issue.