Skip to content

Support for new pool features #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025

Conversation

mulkieran
Copy link
Member

No description provided.

@mulkieran mulkieran self-assigned this Apr 9, 2025
@mulkieran mulkieran moved this to In Progress in 2025April Apr 9, 2025
@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch 5 times, most recently from 56e97f8 to 5a60f20 Compare April 9, 2025 16:35
@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch 5 times, most recently from 49e900d to a28724e Compare April 14, 2025 19:31
@mulkieran
Copy link
Member Author

mulkieran commented Apr 14, 2025

Sample output for stopped pool list:

Test detailed view on a stopped pool. ... ok
UUID: 9b5096da-0966-4964-a1de-e4e341d41c0e
Name: deadpool
Metadata Version: 2
Encryption Enabled: Yes
    Accepts User-Entered Passphrase to Unlock: Yes
    Allows Unattended Unlock via Key in Kernel Keyring: Yes
    Allows Unattended Unlock via Clevis: No
Devices:
7b1d78d0-b5d1-45d0-84ff-1bee82e86ffc  /dev/XZIO
9526e7fb-6266-4db8-989c-7f723f40c876  /dev/RLO1
0e219806-c8a2-40c9-8b36-20762e724c3d  /dev/3NTN
5b036d04-2e1f-4e2b-9489-c5b386596b05  /dev/DNSJ
7a9601c5-2640-4459-9517-e94d112e8d68  /dev/80DU

@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch from 3289c22 to 1924e73 Compare April 14, 2025 20:02
@mulkieran
Copy link
Member Author

mulkieran commented Apr 14, 2025

Another, showing <PRESENT> in table view for stopped pools:

Name       Version   UUID                                   # Devices   Key Description   Clevis
deadpool         2   de05f6b0-0987-47cb-9888-e288aa088051          10   <PRESENT>         N/A 

or

Name       Version   UUID                                   # Devices   Key Description   Clevis   
deadpool         2   25c68f69-0ade-44a5-bf8d-b449bf3f606e           3   N/A               <PRESENT>

@mulkieran
Copy link
Member Author

An unencrypted stopped pool:

UUID: 60f7f102-7b34-4ea4-9a6d-da5fc66c4d45
Name: deadpool
Metadata Version: 2
Encryption Enabled: No
Devices:
3618e8fa-db55-4366-8fa8-3ba019d8654a  /dev/SACP
cca86e20-bb1b-4da2-928a-7d24da1aa7c3  /dev/0ON5

@mulkieran
Copy link
Member Author

/packit build

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratis-cli-1151
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch from 1924e73 to 6aa1a1c Compare April 15, 2025 00:40
@mulkieran
Copy link
Member Author

The FreeTokenSlots are turning into something that maps to an empty string which is very weird.

@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch from 6aa1a1c to a3f179f Compare April 15, 2025 13:57
@mulkieran
Copy link
Member Author

Not an empty string, just an unprintable string in the GitHub CI. Transforming that number to an int should do the trick. This is yet another argument for out-of-dbus-python library.

@mulkieran
Copy link
Member Author

Ok. Now detail view of started is good:

UUID: 64120702-7fd4-41cf-bfbd-565788b262d6
Name: deadpool
Alerts: 0
Metadata Version: 2
Actions Allowed: fully_operational
Cache: No
Filesystem Limit: 10
Allows Overprovisioning: Yes
Encryption Enabled: Yes
    Free Token Slots Remaining: 14
    Token Slot: 1
        Key Description: keydesc
Fully Allocated: No
    Size: 512 EiB
    Allocated: 2.50 GiB
    Used: 0 B

@mulkieran mulkieran changed the title TEMPORARY issue-stratisd-3805 Apr 15, 2025
@mulkieran mulkieran requested review from jbaublitz and drckeefe April 15, 2025 14:12
@mulkieran mulkieran moved this from In Progress to In Review in 2025April Apr 15, 2025
@drckeefe
Copy link
Member

Sample output for stopped pool list:

Test detailed view on a stopped pool. ... ok
UUID: 9b5096da-0966-4964-a1de-e4e341d41c0e
Name: deadpool
Metadata Version: 2
Encryption Enabled: Yes
    Accepts User-Entered Passphrase to Unlock: Yes
    Allows Unattended Unlock via Key in Kernel Keyring: Yes
    Allows Unattended Unlock via Clevis: No
Devices:
7b1d78d0-b5d1-45d0-84ff-1bee82e86ffc  /dev/XZIO
9526e7fb-6266-4db8-989c-7f723f40c876  /dev/RLO1
0e219806-c8a2-40c9-8b36-20762e724c3d  /dev/3NTN
5b036d04-2e1f-4e2b-9489-c5b386596b05  /dev/DNSJ
7a9601c5-2640-4459-9517-e94d112e8d68  /dev/80DU

Would it be possible to only display two values in the Encryption Enabled output? Example:

Encryption Enabled: Yes
Accepts User-Entered Passphrase or existing Kernel Keyring to Unlock: Yes
Allows Unattended Unlock via Clevis: No

I believe that the first two are similar and could be combined.

@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch from 964a65e to 1374a95 Compare April 15, 2025 15:26
@mulkieran
Copy link
Member Author

Revision to stopped pool detail now looks like this:

UUID: ff381dfc-9764-4f59-b0f9-c56acd377f3a
Name: deadpool
Metadata Version: 2
Encryption Enabled: Yes
    Allows Unlock via a Key in Kernel Keyring or a User-Entered Passphrase: Yes
    Allows Unattended Unlock via Clevis: No
Devices:
bc96e183-1119-490e-9239-29be0cb75d55  /dev/1SLG
68edef64-86b7-473a-9597-5db728ca27c8  /dev/C18B

@mulkieran mulkieran moved this from In Review to Pending in 2025April Apr 15, 2025
@mulkieran mulkieran changed the title issue-stratisd-3805 Support for new pool features Apr 15, 2025
@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch from 9b30305 to 0697eaf Compare April 16, 2025 13:38
@mulkieran
Copy link
Member Author

rebased, no conflicts.

@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch 2 times, most recently from c751f9f to 3b3686f Compare April 30, 2025 00:57
@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch from 439e397 to 9012c94 Compare May 5, 2025 16:22
@mulkieran
Copy link
Member Author

rebased

@mulkieran mulkieran added this to 2025May May 5, 2025
@mulkieran mulkieran removed this from 2025April May 5, 2025
@mulkieran mulkieran moved this to In Progress in 2025May May 5, 2025
@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch from 9012c94 to e3e51b3 Compare May 5, 2025 16:36
@mulkieran
Copy link
Member Author

commits squashed

@mulkieran mulkieran moved this from In Progress to In Review in 2025May May 6, 2025
@mulkieran mulkieran force-pushed the issue-stratisd-3805 branch from e3e51b3 to 70a4ef7 Compare May 6, 2025 19:50
@mulkieran mulkieran marked this pull request as ready for review May 6, 2025 19:51
@mulkieran mulkieran merged commit 30f9c30 into stratis-storage:master May 6, 2025
10 checks passed
@mulkieran mulkieran deleted the issue-stratisd-3805 branch May 6, 2025 20:19
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025May May 6, 2025
@mulkieran mulkieran moved this from Done to Done(1) in 2025May May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done(1)
Development

Successfully merging this pull request may close these issues.

3 participants