You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colors defined via QColor(int, int, int) are not search-friendly (pairing color from Figma to name in code). To solve that, comments witch standard hex notation are added.
Colors defined via QColor(int, int, int) are not search-friendly
(pairing color from Figma to name in code). To solve that, comments
witch standard hex notation are added.
Another note: could you pls also update the ColorsPage.qml in Storybook as well? That makes the whole color matching and searching process a lot more helpful 🙂
You can switch the color notation in Figma as well 😀
It doesn't help (or I'm missing sth) bc there is rgba format e.g. rgba(67, 96, 223, 1) where values are decimal. In our code values are hexadecimal, so matching is still problematic.
Another note: could you pls also update the ColorsPage.qml in Storybook as well? That makes the whole color matching and searching process a lot more helpful 🙂
@caybro good point. It actually triggered me to rebuild ColorsPage.qml. Now it automatically inspects ThemePalette and StatusColors, no need to list keys in the page. It means no manual updates when updating palette. Also some nested values not covered earlier now are available.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
micieslak
requested review from
Khushboo-dev-cpp,
caybro,
glitchminer and
noeliaSD
and removed request for
a team
Khushboo-dev-cpp
left a comment
What does the PR do
Colors defined via
QColor(int, int, int)are not search-friendly (pairing color from Figma to name in code). To solve that, comments witch standard hex notation are added.Screencast.from.12.12.2025.01.12.17.webm
Affected areas
statuscolors.h,themepalette.cppImpact on end user
no impact
Risk
no risk