This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Specify the provider in the URL to properly route traffic #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #93 To route to the appropriate provider in CodeGate
aponcedeleonch
commented
Nov 26, 2024
| @@ -1,6 +1,6 @@ | |||
| import json | |||
|
|
|||
| from fastapi import Header, HTTPException, Request | |||
There was a problem hiding this comment.
Unused imports
lukehinds
approved these changes
Nov 26, 2024
Comment on lines
+16
to
+19
| @property | ||
| def provider_route_name(self) -> str: | ||
| return "anthropic" | ||
|
|
There was a problem hiding this comment.
any advantage over just hardcoding the name ? not enough to stop merging, just curious to learn
There was a problem hiding this comment.
I just thought it was better to define provider_route_name as an abstracmethod so that we suddenly not forget to specify it for other providers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #93
To route to the appropriate provider in CodeGate