Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Fix linting errors in CI #89

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix linting errors in CI #89

merged 3 commits into from
Nov 25, 2024

Conversation

lukehinds
Copy link

No description provided.

@lukehinds lukehinds requested review from yrobla and jhrozek November 25, 2024 19:57
@lukehinds
Copy link
Author

@jhrozek some more on top of 0fb76fa

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is correct, but I'm surprised that my code in the tests left so many linting errors around. I'm sure I did run make lint, is there something else that needs to be ran?

@lukehinds
Copy link
Author

@jhrozek do a make all that will cover it all for you.

@lukehinds lukehinds merged commit b975b57 into main Nov 25, 2024
2 checks passed
@lukehinds lukehinds deleted the fix-ci branch November 25, 2024 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants