This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Hard delete workspaces #685
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #669 To hard delete a workspace it first needs to be soft deleted.
peppescg
approved these changes
Jan 21, 2025
JAORMX
suggested changes
Jan 21, 2025
| @@ -431,7 +460,7 @@ async def get_workspaces(self) -> List[WorkspaceActive]: | |||
| workspaces = await self._execute_select_pydantic_model(WorkspaceActive, sql) | |||
| return workspaces | |||
|
|
|||
| async def get_workspace_by_name(self, name: str) -> Optional[Workspace]: | |||
| async def get_non_deleted_workspace_by_name(self, name: str) -> Optional[Workspace]: | |||
There was a problem hiding this comment.
most of the time we'd be dealing with non deleted workspaces. I would suggest keeping the name get_workspace_by_name since it adheres to the expectation.
| @@ -446,6 +475,21 @@ async def get_workspace_by_name(self, name: str) -> Optional[Workspace]: | |||
| ) | |||
| return workspaces[0] if workspaces else None | |||
|
|
|||
| async def get_workspace_by_name(self, name: str) -> Optional[Workspace]: | |||
There was a problem hiding this comment.
should we rename this to deal with the expectation that we're dealing with soft deleted or archived workspaces?
|
superceded by #686 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #669
To hard delete a workspace it first needs to be soft deleted.