This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Implement Basic CI #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2024 11:25
This change introduces a Makefile, which provides tests: `pytest --cov=codegate --cov-report=term-missing` security: `bandit -r src/` lint: `ruff check .` format: `black . && isort .` Along with `install` and `build`. These are then all surfaced within GitHub Actions, along with codecov upload A release file is there, but this may be removed, amended, depending upon are agreed packaging approach at launch Closes: #16
jhrozek
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I haven't tested the actions, but the Makefile looks good and works fine. The actions as well - I know there's been a bit of discussion around whether the publish to pypi makes sense, I really can' t tell (I'm open by default, but I don't know what ramifications would that have for this project), but the code itself is good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a Makefile, which provides
tests:
pytest --cov=codegate --cov-report=term-missingsecurity:
bandit -r src/lint:
ruff check .format:
black . && isort .Along with
installandbuild.These are then all surfaced within GitHub Actions, along with codecov upload
A release file is there, but this may be removed, amended, depending upon are agreed packaging approach at launch.
There are also a few clean ups around formatting, to make ruff happy.
Closes: #16