This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Add secret type and context lines to secret alert #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now we have only stored the redacted secret in the alert string. This PR also stores the type of secret and the surrounding lines in the alert text: ``` "trigger_string": "GitHub - Access Token:\nimport numpy\n\nGITHUB_TOKEN=\"ghp_1J9Z3Z2dfg4dfs23dsfsdf232aadfasdfasfasdf32\"\n\[email protected](\"/providers\", methods=[\"POST\"])\ndef add_provider():", ```
yrobla
approved these changes
Dec 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #365
Until now we have only stored the redacted secret in the alert string. This PR also stores the type of secret and the surrounding lines in the alert text: