Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Non-Functional Requirements #40

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Non-Functional Requirements #40

merged 4 commits into from
Nov 21, 2024

Conversation

lukehinds
Copy link

This commit introduces Non-Functional Requirements:

  1. Config Parser (supporting YAML config file and env vars_
  2. Logging framework (mutliple levels, text or json format, logging errors / warnings to stderr, and info, debug to stdout
  3. CLI structure, basic flags, help, version command.

Test coverage approx 80%

Closes: #9

Luke Hinds added 3 commits November 20, 2024 22:34
This commit introduces Non-Functional Requirements:

1. Config Parser (supporting YAML config file and env vars_
2. Logging framework (mutliple levels, text or json format, logging
errors / warnings to stderr, and info, debug to stdout
3. CLI structure, basic flags, help, version command.

Test coverage approx 80%

Closes: #9
Copy link
Contributor

@ptelang ptelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test work, starting the server works, review done interactively in a call

@lukehinds lukehinds merged commit 970f576 into main Nov 21, 2024
@lukehinds lukehinds deleted the non-func-code branch November 21, 2024 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Non-Functional Requirements: Logging, Configuration Parsing, and Argument Handling etc
3 participants