This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fixup minor string inconsistencies #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use user scope instead of system scope for cert trust
jhrozek
reviewed
Dec 17, 2024
| "sudo security add-trusted-cert -d -r trustRoot " | ||
| "-k /Library/Keychains/System.keychain certs/server.crt" | ||
| "security add-trusted-cert -r trustRoot " | ||
| "-k ~/Library/Keychains/login.keychain certs/server.crt" |
There was a problem hiding this comment.
I don't think this script is used anymore..this is confusing and we need to clean that up, but for now the only instructions are in the UI and the docs. It's not wrong to fix instructions that are not used :-) so let's merge the PR and remove this script later on
(the certs are these days minted in codegate_ca.py)
jhrozek
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nits: