This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Use def in FastAPI dashboard calls.
#222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quote from [FastAPI docs](https://fastapi.tiangolo.com/async/#path-operation-functions) > Path operation functions When you declare a path operation function with normal def instead of async def, it is run in an external threadpool that is then awaited, instead of being called directly (as it would block the server). What we have experienced in Trusty is that if we use `async def` it will queue the requests and wait for them sequentially. While using just `def` will not block the server. This PR used `def` in the dashboard functions to not affect User Experience.
lukehinds
approved these changes
Dec 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote from FastAPI docs
What we have experienced in Trusty is that if we use
async defit will queue the requests and wait for them sequentially (blocking the server). While using justdefwill not block the server as the requests are run in a threadpool. This PR usesdefin the dashboard functions to not affect User Experience blocking the dashboard.