This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Convert async _close_models in LlamaCppInferenceEngine #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RuntimeWarning about unawaited coroutine by converting the async cleanup method to synchronous since it's called from del. Also fixes dictionary iteration and adjusts method name to follow Python protected method conventions. Resolves: #109
ptelang
approved these changes
Dec 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RuntimeWarning about unawaited coroutine by converting the async cleanup method to synchronous since it's called from del. Also fixes dictionary iteration and adjusts method name to follow Python protected method conventions.
Resolves: #109