This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Remove Ollama from Integration Tests #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimitrov
reviewed
Apr 29, 2025
Comment on lines
379
to
385
| else: | ||
| selected_providers = available_providers | ||
|
|
||
| # Exclude ollama provider if it's in the list | ||
| if "ollama" in selected_providers: | ||
| selected_providers.remove("ollama") | ||
| logger.info("Excluded 'ollama' provider from tests.") |
There was a problem hiding this comment.
I think we can leave that there as we might want to run the test locally.
The change in the workflow yml file should be sufficient to skip the ollama tests from running 👍
blkt
previously approved these changes
Apr 29, 2025
|
@blkt @lukehinds - I see Michelangelo liked the suggestion so I hope you don't mind that I'll push on top of this PR to revert only that change so we can merge the rest |
Signed-off-by: Radoslav Dimitrov <[email protected]>
blkt
approved these changes
Apr 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to test this by pushing