This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Add instance table along with init code.
#1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blkt
force-pushed
the
feat/add-instance-details-table-and-init
branch
2 times, most recently
from
70b2d6e to
6c8e407
Compare
JAORMX
reviewed
Mar 6, 2025
| SELECT RAISE(FAIL, 'only one instance!'); | ||
| END; | ||
| """ | ||
| ) |
There was a problem hiding this comment.
could we have a trigger that prevents deletion of the one row as well?
There was a problem hiding this comment.
I would avoid adding a constraint on deletion, it becomes cumbersome to modify the table since AFAIK you cannot disable triggers temporarily in sqlite, which means you'd have to rely on DROP TABLE/CREATE TABLE to fix any sort of issue.
Additionally, it's hard to delete that record by mistake since there's no delete_instance routine in DbRecorder and initialization takes care of recreating it.
I'm inclined to let this as is, but I'm not religious about it, we can add it now or later anyway.
JAORMX
previously approved these changes
Mar 6, 2025
This change adds an `instance` table containing the minimum set of details about codegate. We might want to add more details in the future. The table must contain only a single record at any time. To guarantee that, a trigger is added that prevents inserts beyond the first record. Finally, code performing the initialization is added to the `serve` command.
blkt
force-pushed
the
feat/add-instance-details-table-and-init
branch
from
6c8e407 to
dd29ba2
Compare
JAORMX
approved these changes
Mar 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an
instancetable containing the minimum set of details about codegate. We might want to add more details in the future.The table must contain only a single record at any time. To guarantee that, a trigger is added that prevents inserts beyond the first record.
Finally, code performing the initialization is added to the
servecommand.