This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Add formatting step to CI #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: poppysec <[email protected]>
jhrozek
reviewed
Nov 28, 2024
| @@ -48,6 +48,9 @@ jobs: | |||
| - name: Run linting | |||
| run: make lint | |||
|
|
|||
| - name: Run formatting | |||
There was a problem hiding this comment.
should we make the CI step explicitly fail if there are any changes afterwards?
if [[ -n "$(git status --porcelain)" ]]; then
echo "Formatting produced changes. Please run 'make format' locally and commit the changes."
exit 1
fi
There was a problem hiding this comment.
I think it might actually fail is , should do a sys.exit code of 1, but I will check
There was a problem hiding this comment.
So this will automatically format everything in the PR, unless that command fails, at which point CI will fail too.
lukehinds
approved these changes
Nov 28, 2024
| @@ -48,6 +48,9 @@ jobs: | |||
| - name: Run linting | |||
| run: make lint | |||
|
|
|||
| - name: Run formatting | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.