This repository was archived by the owner on Jun 5, 2025. It is now read-only.
FIM related fixes for alerts and DB #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple of fixes for this PR: 1. Return conversations with empty answers in the special case of FIM. Sometimes FIM doesn't give us an answer 2. Use the function to deduplicate alerts for all type of alerts 3. Fix a SQL query in which there were some messages being filtered out 4. Record FIM interactions in DB. They were being skipped.
jhrozek
approved these changes
Feb 21, 2025
yrobla
approved these changes
Feb 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of fixes for this PR: