This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix API alerts and storing of PII alerts #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aponcedeleonch
force-pushed
the
fix-pii-alerts
branch
from
5bc975b to
5b2b1ff
Compare
aponcedeleonch
changed the title
We had some small bugs related with alerts: 1. The function for deduping alerts was only returning alerts related to secrets. All the other alerts were being dropped when calling this function. 2. We were returning non-critical alerts in the `/messages/` endpoint 3. PII alerts were never recorded because the context was never passed to the function. Discovered by @kd This PR fixes the 3 of them and introduces some unit tests.
aponcedeleonch
force-pushed
the
fix-pii-alerts
branch
from
5b2b1ff to
9db2d55
Compare
kantord
approved these changes
Feb 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some small bugs related with alerts:
/messages/endpointThis PR fixes the 3 of them and introduces some unit tests.