Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Implement an interface to centralize the client differences #831

Open
jhrozek opened this issue Jan 29, 2025 · 3 comments
Open

Implement an interface to centralize the client differences #831

jhrozek opened this issue Jan 29, 2025 · 3 comments
Assignees
@jhrozek

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Jan 29, 2025

Building atop the client detection in #830 we should add a client interface to centralize the differences between clients.
@lukehinds
Copy link

@blkt may make sense to do this at the same time as normalizers work

@jhrozek jhrozek assigned jhrozek and unassigned blkt Feb 4, 2025
@jhrozek
Copy link
Contributor Author

jhrozek commented Feb 4, 2025

I'm going to send out a first version of the interface, I think most of it could be reused/adapted when we rip out the ChatCompletionRequest.

@jhrozek
Copy link
Contributor Author

jhrozek commented Mar 4, 2025

when doing this, also pre-compile the regexes that are currently in the pipeline's CLI step

jhrozek added a commit that referenced this issue Mar 5, 2025
@jhrozek
Strip code snippets through a client interface
82561eb 
Different clients need different ways of stripping away the context in
order to analyze just the human text in the user message. Let's start
with this as the first method of a client interface.

Related: #831
@jhrozek jhrozek mentioned this issue Mar 5, 2025
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhrozek jhrozek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blkt @jhrozek @lukehinds