Skip to content

fix: add missing security group ID output to security-group create command #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

marceljk
Copy link
Contributor

@marceljk marceljk commented Jul 8, 2025

Description

relates to #845

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner July 8, 2025 15:57
@marceljk marceljk linked an issue Jul 8, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jul 8, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/security-group/create 38.18% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/security-group/create/create.go 38.18% (ø) 55 21 34

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@marceljk marceljk merged commit 64f3f14 into main Jul 9, 2025
5 checks passed
@marceljk marceljk deleted the 845-cli-security-group-create-does-not-return-id branch July 9, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: security-group create does not return ID
2 participants