Skip to content

[Merged by Bors] - Allow configuring CSI docker images #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sbernauer
Copy link
Member

Description

Fixes #60. For https://github.com/orgs/stackabletech/discussions/14
Backport of stackabletech/secret-operator#235 for listener-operator

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr
Copy link
Contributor

nightkr commented Mar 14, 2023

You also need to update the controller:

- name: external-provisioner
image: k8s.gcr.io/sig-storage/csi-provisioner:v3.1.0
args:
- --csi-address=/csi/csi.sock
- --feature-gates=Topology=true
- --extra-create-metadata

@sbernauer sbernauer requested a review from nightkr March 14, 2023 08:52
@sbernauer
Copy link
Member Author

sbernauer commented Mar 14, 2023

Good catch, thx! We actually do things differently here

Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, changelog still needs update though

@sbernauer
Copy link
Member Author

bors r+
Thx for review!

bors bot pushed a commit that referenced this pull request Mar 14, 2023
@bors
Copy link

bors bot commented Mar 14, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Allow configuring CSI docker images [Merged by Bors] - Allow configuring CSI docker images Mar 14, 2023
@bors bors bot closed this Mar 14, 2023
@bors bors bot deleted the feature/configure-csi-images branch March 14, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CSI docker images configurable
2 participants