-
-
Notifications
You must be signed in to change notification settings - Fork 12
ADR 29: Standardize database connections #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick pass, just doing minor writing stuff.
Some questions, just writing them down, would suggest to have a call about them:
- Is
DatabaseConnection
namespaced? Would be fine for me. If not we would have to use aSecretClass
as Secrets are namespaced - What do you think of a complex enum within
DatabaseConnection
? - I personally don't like putting something like
driver
pr protocol into the global CRD. That seems like a implementation detail of the individual product to me
Just throwing in an idea that should address the above points
apiVersion: databaseconnection.stackable.tech/v1alpha1
kind: DatabaseConnection
metadata:
name: druid-metadata-connection
namespace: default
spec:
database:
postgresql:
host: druid-postgresql # mandatory
port: 5432 # defaults to some port number - depending on wether tls is enabled
schema: druid # defaults to druid
credentials: druid-postgresql-credentials # mandatory. key username and password
parameters: "" # optional
redis:
host: airflow-redis-master # mandatory
port: 6379 # defaults to some port number - depending on wether tls is enabled
schema: druid # defaults to druid
credentials: airflow-redis-credentials # optional. key password. In case redis also supports usernames key username and password
parameters: "" # optional
derby:
location: /tmp/derby/ # optional, defaults to /tmp/derby-{metadata.name}/derby.db
parameters: "create=true" # optional
When we add tls support, things get more tricky
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
48f33a8
to
fd414be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Triggered by stackabletech/hive-operator#148
Fixes stackabletech/issues#238