Skip to content

chore(zookeeper): remove jmx exporter #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Jun 12, 2025

Description

Part of stackabletech/zookeeper-operator#954

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Jun 12, 2025
razvan
razvan previously approved these changes Jun 12, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm :)

@xeniape xeniape added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit fcdb3dc Jun 13, 2025
3 checks passed
@xeniape xeniape deleted the chore/remove-jmx-exporter-zookeeper branch June 13, 2025 12:07
xeniape added a commit that referenced this pull request Jun 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 16, 2025
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jun 17, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants