Skip to content

chore: modularize Dockerfiles #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025
Merged

chore: modularize Dockerfiles #1118

merged 11 commits into from
May 19, 2025

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented May 19, 2025

Description

This only works with an upcoming release of https://github.com/stackabletech/image-tools that includes stackabletech/image-tools#51

Moves some components into separate Dockerfiles:

  • Phoenix
  • HBase Operator Tools
  • HBase OPA Authorizer
  • statsd_exporter
  • kcat
  • trino-storage-connector

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@dervoeti dervoeti requested a review from razvan May 19, 2025 06:46
@dervoeti dervoeti force-pushed the feat/modularize-dockerfiles branch from 3ac5615 to c12beb3 Compare May 19, 2025 08:13
razvan added 2 commits May 19, 2025 11:53
* chore(omid): bump to version 1.1.3

* update changelog

* fix 1.1.3/patachable.toml

* fix markdown lint
razvan
razvan previously approved these changes May 19, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dervoeti dervoeti force-pushed the feat/modularize-dockerfiles branch from cb45142 to e34c4d4 Compare May 19, 2025 10:48
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dervoeti dervoeti added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit e29d4df May 19, 2025
3 checks passed
@dervoeti dervoeti deleted the feat/modularize-dockerfiles branch May 19, 2025 11:37
NickLarsenNZ added a commit that referenced this pull request May 28, 2025
Note: Should have been done as part of #1118
github-merge-queue bot pushed a commit that referenced this pull request Jun 1, 2025
* chore(hive): Bump dependencies ahead of 25.7.0

* fix(java): Use vector 0.46.1

This was missed in #1098

* chore(hive): Patch postgres to resolve CVE-2024-1597

* chore(nix): Bump image-utils for newer bake

Note: Should have been done as part of #1118

* chore(nix): Bump nixpkgs and install nodejs_20 to keep pre-commit happy

I was getting the following error:

```
An unexpected error has occurred: CalledProcessError: command: ('/nix/store/15jzs4a11nqp4m1xvnw0rz9395anzjsm-nodejs-18.20.8/bin/node', '/run/current-system/sw/bin/npm', 'install', '--include=dev', '--include=prod', '--ignore-prepublish', '--no-progress', '--no-save')
return code: 1
stdout: (none)
stderr:
    npm error code EBADENGINE
    npm error engine Unsupported engine
    npm error engine Not compatible with your version of node/npm: [email protected]
    npm error notsup Not compatible with your version of node/npm: [email protected]
    npm error notsup Required: {"node":">=20"}
    npm error notsup Actual:   {"npm":"10.8.2","node":"v18.20.8"}
    npm error A complete log of this run can be found in: /home/nick/.npm/_logs/2025-05-28T10_40_07_463Z-debug-0.log
Check the log at /home/nick/.cache/pre-commit/pre-commit.log
```

* chore(hive): Revert hadoop and aws bumps, update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants