Skip to content

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Aug 29, 2025

Description

Fixes #637 and #200.

🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/56/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible 🟢 tests
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added for the dag-processor. Also here (triggerer).

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 moved this to Development: In Progress in Stackable Engineering Aug 29, 2025
@adwk67 adwk67 self-assigned this Aug 29, 2025
@adwk67 adwk67 marked this pull request as ready for review September 8, 2025 11:58
@adwk67 adwk67 moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Sep 8, 2025
@adwk67 adwk67 requested a review from a team September 8, 2025 12:24
@maltesander maltesander self-requested a review September 9, 2025 05:42
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 9, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, LGTM otherwise!

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are some yamls in the example folder that could showcase this as well?

@adwk67 adwk67 added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 138f333 Sep 9, 2025
17 checks passed
@adwk67 adwk67 deleted the feat/add-processor-triggerer-roles branch September 9, 2025 10:51
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Sep 9, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Airflow 3.x: split DAG-Processor service into its own role.
3 participants