Skip to content

feat: add filtering options to svelteJsxSnippet plugin #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2024
Merged

feat: add filtering options to svelteJsxSnippet plugin #21

merged 3 commits into from
Jul 24, 2024

Conversation

ryoppippi
Copy link
Contributor

Hi
I added an option to change include/exclude filter for vite plugin!

This commit introduces the ability to include or exclude files from
being processed by the svelteJsxSnippet plugin. This is achieved by
using the createFilter function from the @rollup/pluginutils package.
The filtering options can be passed as an argument to the
svelteJsxSnippet function.
@ssssota
Copy link
Owner

ssssota commented Jul 24, 2024

@ryoppippi Thanks for your contribution! Please format with pnpm fmt.

@ryoppippi
Copy link
Contributor Author

@ssssota Hi! I ran the fmt command!

@ssssota
Copy link
Owner

ssssota commented Jul 24, 2024

@rollup/pluginutils の中で使ってるpicomatchがCJSで require("path") しているせいでビルドに失敗していそう

@ssssota
Copy link
Owner

ssssota commented Jul 24, 2024

I think we should move @rollup/pluginutils from devDependencies to the dependencies field

@ryoppippi
Copy link
Contributor Author

maybe we can add some options to tsconfig.json

@ryoppippi
Copy link
Contributor Author

I just move rollup/utils to the dependency and it works as you said

@ssssota
Copy link
Owner

ssssota commented Jul 24, 2024

We did it! Thank you!

@ssssota ssssota merged commit 16d6f07 into ssssota:main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants