Disable restart policy on celery when running dev mode #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since celery in dev mode is replaced by 'tianon/true', which exit fast,
the restart policy should be "no" in order to avoid entering in a restart loop.
The "no" needs to be escaped because it must be a "string", and the quotes (")
would be removed by 'awk' when processing the 'docker-compose.override.yml' template.
Signed-off-by: David Pordomingo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #317
blocks #320
Since
sourced-ui-celeryin dev mode is replaced bytianon/true, which exits fast, the restart policy should be"no"in order to avoid entering in a restart loop.The
\"no\"needs to be escaped because it must be a "string", and otherwise, the quotes (") would be removed byawkwhen processing thedocker-compose.override.ymltemplate.