Validate params for orgs init #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is there any downside if we used the regular go-github lib? |
Contributor
Author
|
I didn't use go-github here on purpose to accent that this code is a temporary solution. I truly believe cli shouldn't talk directly to github for orgs and token validation. |
carlosms
approved these changes
Jun 21, 2019
Contributor
carlosms
left a comment
carlosms
left a comment
There was a problem hiding this comment.
I'm not too happy redoing the code that go-github already does, even if it's a small part.
But we can use it as it is and discuss later how to improve.
Contributor
Author
|
I'm glad you don't like it so we can remove it after release :) |
Fix: #59 It's the simplest possible implementation that is good enough for now and easy to remove later. Signed-off-by: Maxim Sukharev <[email protected]>
Contributor
Author
|
rebased on master. merge after CI pass. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #59
It's the simplest possible implementation that is good enough for now
and easy to remove later.
Signed-off-by: Maxim Sukharev [email protected]