fix: compatible with ortools 8 and ortools 9. #8
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarkovtsev
requested changes
Nov 8, 2021
Collaborator
vmarkovtsev
left a comment
vmarkovtsev
left a comment
There was a problem hiding this comment.
Many thanks for the PR! Awesome contribution 👍
How to accept DCO: https://github.com/src-d/seriate/pull/8/checks?check_run_id=4138225952
We need it to avoid legal problems in the future.
|
@zouguangxian Any way you can accept the DCO? It would be great to get this working for ortools 9 . |
Signed-off-by: Zou Guangxian <[email protected]>
zouguangxian
force-pushed
the
compatible-with-ortools9
branch
from
3246ec8 to
81fd18f
Compare
Author
I've accepted DCO. Ty |
|
@vmarkovtsev can this now be merged and a new version be pushed to pypi? |
|
bump |
|
Hey, what is the status of this? Would be great to have this on pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.