Removes merge field from ReviewEvent and regenerates files #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like the code generated by you and by travis is different. Maybe there is a problem with the versions used. |
Signed-off-by: Lou Marvin Caraig <[email protected]>
se7entyse7en
force-pushed
the
merge-field-removal
branch
from
21e398e to
b2e2d17
Compare
Contributor
Author
|
@carlosms you're right, the version was wrong. Thanks! |
Contributor
|
Maybe we should make the field reserved? |
Contributor
Author
|
@carlosms I don't completely understand what is the case that would cause problems. AFAIU the problem arises if now we remove it and then let's say next week we add another field with the same name and number, but for example a different type. But that could be a problem if that object is interpreted using the old version of the proto file right? |
Contributor
|
imo we are still at the very early stage of lookout and pollute it with reserved doesn't make much sense to me. |
Contributor
|
🤷♂️ ok let's skip the reserved |
carlosms
approved these changes
Feb 14, 2019
smacker
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First task from issue: src-d/lookout#83.